debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtinfo: Fix coverity issues for resource leaks

Browse Source
This commit is contained in:
Peter Howkins
2018-04-04 22:07:10 +01:00
parent 9ef3b9ec68
commit 2b15c4057e
11 changed files with 47 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cde/programs/dtinfo/DtMmdb/storage/page.C
View File

@@ -413,15 +413,17 @@ Boolean page::_alloc_slot( int slot_num, int size, char*& str_ptr )
int new_blank_len = slot_info -> string_leng() ;
if ( new_blank_len < size )
if ( new_blank_len < size ) {
delete slot_info;
return false;
}
slot_info -> set_string_ofst( end_ptr );
slot_info -> set_string_leng( size );
slot_info -> set_mode(spointer_t::DELETED, false);
slot_info -> set_forward_ptr(0);
delete slot_info;
delete slot_info;
if ( slot_num == count() ) {

4
cde/programs/dtinfo/DtMmdb/storage/page_storage.C
View File

@@ -698,8 +698,10 @@ int page_storage::deleteString(mmdb_pos_t loc, Boolean flush_opt)
spointer_t *x = y -> get_spointer(slot_num);
if ( x -> get_mode(spointer_t::DELETED) == true )
if ( x -> get_mode(spointer_t::DELETED) == true ) {
delete x;
return 0;
}
loc = x -> forward_ptr();
//debug(cerr, loc);