dtmail: Further Coverity fixes

2018-04-24 02:38:56 +01:00
parent 9088d6b54e
commit 3cf92f3741
26 changed files with 113 additions and 87 deletions
--- a/cde/programs/dtmail/libDtMail/Common/POP3Server.C
+++ b/cde/programs/dtmail/libDtMail/Common/POP3Server.C
@@ -486,8 +486,9 @@ POP3Server::uidlist_read(DtVirtArray<char*> *uidlist)
 	while (NULL != fgets(uidliststr, DTMAS_POPBUFSIZE, fp))
 	  if (sscanf(uidliststr, "%d %s", &curmsg, curuidstr) == 2)
 	    uidlist->append(strdup(uidliststr));
+
+	fclose(fp);
    }
-    fclose(fp);
 }

 void
@@ -506,7 +507,6 @@ POP3Server::uidlist_write(DtVirtArray<char*> *uidlist)
 	    uidliststr = (*uidlist)[i];
 	    fprintf(fp, "%s\n", uidliststr);
        }
+        fclose(fp);
    }
-    fclose(fp);
-
 }