debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtcreate: Fix major buffer overflow

Browse Source 
This code always buffer overflowed, because exactly 2 bytes
less than were used were allocated. This led to dtcreate
crashing when hitting "Find Set..."
This commit is contained in:
Frederic Koehler
2012-08-16 21:04:56 -04:00
committed by Jon Trulson
parent a128f8e4e4
commit 466191d669
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cde/programs/dtcreate/cmncbs.c
View File

@@ -106,7 +106,7 @@ void activateCB_open_FindSet (Widget find_set_button, XtPointer cdata,
pre = GETMESSAGE(3, 10, "Create Action"); pre = GETMESSAGE(3, 10, "Create Action");
suf = GETMESSAGE(6, 18, "Find Set"); suf = GETMESSAGE(6, 18, "Find Set");
dialog_title = XtMalloc(strlen(pre) + strlen(suf) + 2); dialog_title = XtMalloc(strlen(pre) + strlen(suf) + 4);
sprintf(dialog_title, "%s - %s", pre, suf); sprintf(dialog_title, "%s - %s", pre, suf);
#ifdef DEBUG #ifdef DEBUG