debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dthelp: Further coverity fixes

Browse Source
This commit is contained in:
Peter Howkins
2018-04-30 04:11:44 +01:00
parent c936a8c065
commit 48b97a4c41
15 changed files with 76 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cde/programs/dthelp/dthelpprint/PrintManStrFile.c
View File

@@ -218,10 +218,11 @@ int _DtHPrPrintManPage(
}
/* Alloc max shell command line len */
printCommand = malloc(MAX_COMMAND_LENGTH*sizeof(char));
printCommand = malloc(MAX_COMMAND_LENGTH);
if (printCommand == NULL)
{
fprintf(stderr, _DTGETMESSAGE(PMSET,5,
"%s: Error: memory allocation failed\n"),
options->programName );
@@ -231,7 +232,7 @@ int _DtHPrPrintManPage(
/** generate the command **/
snprintf(cmdFormat, sizeof(cmdFormat), "%s %s", /* man */
options->manCommand, options->manArgs);
snprintf(printCommand, sizeof(MAX_COMMAND_LENGTH*sizeof(char)), cmdFormat,
snprintf(printCommand, MAX_COMMAND_LENGTH, cmdFormat,
options->manPage); /* man */
retval = _DtHPrGenFileOrPrint(options,options->manPage,printCommand);