dthelp: Further coverity fixes

This commit is contained in:
Peter Howkins
2018-04-30 04:11:44 +01:00
parent c936a8c065
commit 48b97a4c41
15 changed files with 76 additions and 55 deletions

View File

@@ -166,13 +166,16 @@ void CloseHelpCB (
pTemp = pCacheListHead;
/* Search our Cache List for the closed help dialog */
while ((pTemp->helpDialog != helpDialog) && (pTemp != NULL))
while ((pTemp != NULL) && (pTemp->helpDialog != helpDialog))
pTemp = pTemp->pNext;
if (pTemp == NULL)
if (pTemp == NULL) {
/* ERROR */
printf("We did not find our help dialog widget in the cache list??? /n");
/* TODO what error handling here? */
return;
}
/* Un Map and Clean up the help widget */
XtUnmanageChild(helpDialog);