lidtsvc: coverity fixes

cde/lib/DtSvc/DtEncap/connect.c

@@ -74,6 +74,7 @@ XeCreateContextString(XeString host,
 
    if ((strequal(directory, (XeString)"")) || (directory == NULL)){
       if ((strequal(file, (XeString)"")) || (file == NULL)){
+         Xe_release_str(host);
 	 return((XeString) NULL);
       } else {
 	 context_string = XeMalloc (strlen(host) + strlen(file) + 2);

cde/lib/DtSvc/DtEncap/noio.c

@@ -197,6 +197,7 @@ static char * get_tmp_dir (
    if (is_dir_usable (dir))
       return (dir);
 
+   free(dir);
    return (NULL);
 }
 

cde/lib/DtSvc/DtEncap/pipe.c

@@ -89,6 +89,7 @@ Wire *getpipe(Wire *prevwire)
   /* Get file descriptors for pipe */
   if (pipe(wire_ptr->fd) < OK) {
     SPC_Error(SPC_No_Pipe);
+    XeFree(wire_ptr);
     return(SPC_ERROR);
   }
   return(wire_ptr);

cde/lib/DtSvc/DtEncap/spc-exec.c

@@ -441,9 +441,11 @@ int exec_proc_local_channel_object(SPC_Channel_Ptr channel)
 	}
     }
 
-    if(mempf0(channel, pre_fork)==SPC_ERROR)
-	return(SPC_ERROR);
-    
+    if(mempf0(channel, pre_fork)==SPC_ERROR) {
+        XeFree(dir);
+        return(SPC_ERROR);
+    }
+
     /* When using HP NLIO (xj0input) we have a problem.  Namely,  */
     /* the xj0 processs uses signal() to deal with SIGCLD which   */	
     /* is incompatible with sigaction/sigprogmask/etc.  Even      */
@@ -458,9 +460,11 @@ int exec_proc_local_channel_object(SPC_Channel_Ptr channel)
     sigemptyset(&oldsigmask);
     sigaddset(&newsigmask, SIGCHLD);
     
-    if (sigprocmask(SIG_BLOCK, &newsigmask, &oldsigmask) == ERROR)
-	return(SPC_ERROR);
-    
+    if (sigprocmask(SIG_BLOCK, &newsigmask, &oldsigmask) == ERROR) {
+        XeFree(dir);
+        return(SPC_ERROR);
+    }
+
     pid = channel->pid = fork();
     
     /*

cde/lib/DtSvc/DtEncap/spc-net.c

@@ -344,8 +344,10 @@ SPC_Contact_Server(SPC_Connection_Ptr connection)
   memcpy(&saddr.sin_addr, remote->h_addr, remote->h_length);
 
   if(connect(connection->sid, (struct sockaddr *)&saddr, sizeof(saddr)) == ERROR) {
-    SPC_Error(SPC_Bad_Connect,
-	      XeFindShortHost(remote->h_name));
+    XeString shorthost = XeFindShortHost(remote->h_name);
+    SPC_Error(SPC_Bad_Connect, shorthost);
+    XeFree(shorthost);
+    
     return(SPC_ERROR);
   }
 

cde/lib/DtSvc/DtEncap/spc-proto.c

@@ -768,8 +768,10 @@ int SPC_Write_Protocol_Request (SPC_Connection_Ptr connection,
     envp=va_arg(ap, XeString *);
     va_end(ap);
     pdata->len=WRITE_APPLICATION_SPAWN(pdata, path, dir, argv, envp);
-    if(pdata->len == SPC_ERROR)
+    if(pdata->len == SPC_ERROR) {
+      SPC_Free_Protocol_Ptr(prot_request);
       return(SPC_ERROR);
+    }
     prot_name=(XeString)"  <-- APPLICATION_SPAWN";
     break;
     }
@@ -929,6 +931,7 @@ int SPC_Write_Protocol_Request (SPC_Connection_Ptr connection,
     if(connection->protocol_version < 3) {
       SPC_Error(SPC_Protocol_Version_Error,
 		3, channel->connection->protocol_version);
+      SPC_Free_Protocol_Ptr(prot_request);
       return(SPC_ERROR);
     }
   
@@ -940,6 +943,7 @@ int SPC_Write_Protocol_Request (SPC_Connection_Ptr connection,
     if(connection->protocol_version < 3) {
       SPC_Error(SPC_Protocol_Version_Error,
 		3, channel->connection->protocol_version);
+      SPC_Free_Protocol_Ptr(prot_request);
       return(SPC_ERROR);
     }
   
@@ -958,6 +962,7 @@ int SPC_Write_Protocol_Request (SPC_Connection_Ptr connection,
       buffer = SPC_Decode_Termios(termios_ptr);
       pdata->len=WRITE_TERMIOS(pdata, connector, side, buffer);
       prot_name=(XeString)"  <-- CHANNEL_TERMIOS";
+      free(buffer);
       break;
     }
 
@@ -965,6 +970,7 @@ int SPC_Write_Protocol_Request (SPC_Connection_Ptr connection,
     if(connection->protocol_version < 3) {
       SPC_Error(SPC_Protocol_Version_Error,
 		3, channel->connection->protocol_version);
+      SPC_Free_Protocol_Ptr(prot_request);
       return(SPC_ERROR);
     }
 
@@ -1229,8 +1235,10 @@ char **SPC_Get_Multi_Packet(SPC_Connection_Ptr connection,
       if(localprot)
 	SPC_Free_Protocol_Ptr(localprot);
       prot=SPC_Filter_Connection(connection, NULL, request, TRUE);
-      if(prot==SPC_ERROR)
-	return(SPC_ERROR);
+      if(prot==SPC_ERROR) {
+        free(out);
+        return(SPC_ERROR);
+      }
       print_protocol_request(name, prot);
       localprot=prot;
       bufptr=PDRP(prot->dataptr);
@@ -1442,6 +1450,8 @@ sscan_application_data(XeString buf,
   *envp=sscan_counted_string(bufptr, &bufptr);
   if(*envp==SPC_ERROR)
     return(SPC_ERROR);
+    
+  return(TRUE);
 }
 
 /*----------------------------------------------------------------------+*/
@@ -1657,7 +1667,7 @@ int SPC_Query_Logfile(SPC_Channel_Ptr channel)
   
   READ_LOGFILE_REPLY(prot->dataptr, &channel->logfile, &junk1, &junk2);
   if (junk1) XeFree(junk1);
-  if (junk1) XeFree(junk2);
+  if (junk2) XeFree(junk2);
 		     
   SPC_Free_Protocol_Ptr(prot);
   return (TRUE);
@@ -1811,6 +1821,7 @@ SPC_Validate_User(XeString hostname,
     tt_free (path);
     XeFree(connection_hostname);
     if (logfile) XeFree(logfile);
+    close(open_status);
     return(SPC_ERROR);
   }