lidtsvc: coverity fixes

cde/lib/DtSvc/DtUtil2/EnvControl.c

@@ -1293,7 +1293,7 @@ _DtWsmSetBackdropSearchPath (
 
 	    if (postDtEnvironmentString != postDtEnvironmentStringBuf)
 	    {
-	        if (postDtEnvironmentString) XtFree(postDtEnvironmentString);
+	        XtFree(postDtEnvironmentString);
 		postDtEnvironmentString = NULL;
 	    }
 

cde/lib/DtSvc/DtUtil2/PrintXErr.c

@@ -55,6 +55,9 @@ _DtPrintDefaultError(
 {
     _DtPrintDefaultErrorSafe(dpy, event, msg, BUFSIZ);
     /* XXX retval? */
+    
+    /* COV: 87468 nothing actually checks this return value */
+    return(1);
 }
 
 #define _DTP_STRNCAT(s1, s2, nb, ec) \

cde/lib/DtSvc/DtUtil2/SmCreateDirs.c

@@ -33,6 +33,7 @@
  *
  *****************************************************************************/
 
+#include <stdio.h>
 #include <sys/param.h>
 #include <sys/types.h>
 #include <sys/stat.h>
@@ -322,8 +323,8 @@ GetDisplayName (
     /*
      * Create the display name and append it to the current path.
      */
-    (void)strcpy(hostName, display->display_name);
-    (void)strcpy(displayName, display->display_name);
+    snprintf(hostName, sizeof(hostName), "%s", display->display_name);
+    snprintf(displayName, sizeof(displayName), "%s", display->display_name);
     
     /*
      * If this is run to unix or local get the host name - otherwise