dtinfo: Resolve coverity warnings related to uninitialised members of classes

This commit is contained in:
Peter Howkins
2018-04-19 23:25:47 +01:00
parent 02d43dabe6
commit 6e7e9d91e1
48 changed files with 167 additions and 32 deletions

View File

@@ -35,7 +35,10 @@ public:
BookmarkEdit (UAS_Pointer<Mark> &mark)
: f_mark_ptr (mark),
f_shell (NULL),
f_modified (FALSE)
f_modified (FALSE),
f_name_text(NULL),
f_notes_text(NULL),
f_wm_delete_callback(NULL)
{
MarkMgr::request ((UAS_Receiver<MarkMoved> *) this);
}

View File

@@ -121,7 +121,12 @@ GraphicAgent::GraphicAgent (UAS_Pointer<UAS_Common> &node_ptr,
f_panner_state (PANNER_NONE),
f_current_scale (100),
f_scale_button(NULL),
f_setcustom(0)
f_setcustom(0),
f_panner(NULL),
f_pixmap_widget(NULL),
f_view_menu(NULL),
f_message_area(NULL),
f_custom_scale(NULL)
{
f_graphic->pixmap_graphic()->agent(this);

View File

@@ -133,7 +133,8 @@ HelpAgent *HelpAgent::g_help_agent;
// /////////////////////////////////////////////////////////////////
HelpAgent::HelpAgent()
: f_helper (NULL)
: f_helper (NULL),
f_appXrmDb(NULL)
{
Widget app_shell = window_system().toplevel();
f_cursor = create_help_cursor(app_shell);

View File

@@ -136,6 +136,21 @@ LibraryAgent::LibraryAgent()
f_tracking_hierarchy (NULL),
f_popped_down (TRUE),
f_close (NULL),
f_close_sensitive (FALSE)
f_close_sensitive (FALSE),
f_doc_tree_view(),
f_copy(NULL),
f_detach(NULL),
f_detach2(NULL),
f_view(NULL),
f_view2(NULL),
f_print(NULL),
f_print2(NULL),
f_print_as(NULL),
f_remove(NULL),
f_remove2(NULL),
f_auto_track(NULL),
f_status_text(NULL),
f_scope_menu(NULL)
{
}

View File

@@ -220,7 +220,16 @@ MapButton::destroy()
MapAgent::MapAgent()
: f_shell (NULL),
f_onscreen (FALSE)
f_onscreen (FALSE),
f_locked(FALSE),
f_map_mode(LOCAL_MODE),
f_porthole(NULL),
f_panner(NULL),
f_tree(NULL),
f_wm_delete_callback(NULL),
f_lock(NULL),
f_min_tree_width(0),
f_min_tree_height(0)
{
}

View File

@@ -84,7 +84,8 @@
MarkChooser::MarkChooser (Widget parent, xList<MarkCanvas *> &marks,
const char *title_key, const char *ok_key)
: f_selected_item (-1),
f_mark_list (&marks)
f_mark_list (&marks),
f_done(FALSE)
{
create_ui (parent, title_key, ok_key);
update_list();

View File

@@ -82,7 +82,8 @@
MarkListView::MarkListView()
: f_shell (NULL),
f_popped_up (FALSE)
f_popped_up (FALSE),
f_selected_item(0)
{
}

View File

@@ -72,6 +72,10 @@ private: // variables
inline
MessageAgent::MessageAgent()
: f_dialog (NULL),
f_exit_flag (False)
f_exit_flag (False),
f_text(NULL),
f_real_parent(NULL),
f_popped_up(FALSE),
f_pressed_ok(FALSE)
{
}

View File

@@ -38,7 +38,7 @@ class NodeHistoryAgent : public WWL,
{
public: // functions
NodeHistoryAgent()
: f_shell (NULL), f_selected_item (0)
: f_shell (NULL), f_selected_item (0), f_popped_up(FALSE)
{ }
virtual ~NodeHistoryAgent();
void display();

View File

@@ -40,7 +40,16 @@ class WXmPanedWindow;
class NodeListAgent : public Agent
{
public: // functions
NodeListAgent() {}
NodeListAgent() :
f_shell(NULL),
f_form(NULL),
f_menu_bar(NULL),
f_list_form(NULL),
f_list(NULL),
f_panel(NULL),
f_pane(NULL),
f_wm_delete_callback(NULL)
{}
~NodeListAgent();
void init ();

View File

@@ -278,7 +278,7 @@ _DtHelpCreatePrintArea(Widget parent,
// /////////////////////////////////////////////////////////////////
NodePrintAgent::NodePrintAgent()
: f_node_view_info (NULL), f_help_dsp_area(NULL)
: f_node_view_info (NULL), f_help_dsp_area(NULL), f_form(NULL)
{
}

View File

@@ -787,7 +787,34 @@ NodeWindowAgent::NodeWindowAgent (u_int serial_no)
f_hscrollbar_offset(0),
f_graphic_segment(NULL),
f_graphics_handler(NULL),
f_close_sensitive(FALSE)
f_close_sensitive(FALSE),
f_frame(NULL),
f_create_bmrk(NULL),
f_create_anno(NULL),
f_create_link(NULL),
f_move_mark(NULL),
f_edit_mark(NULL),
f_delete_mark(NULL),
f_detach_graphic(NULL),
f_detach_menu(NULL),
f_detach_button(NULL),
f_attach_button(NULL),
f_raise_button(NULL),
f_preview_menu(NULL),
f_preview_label(NULL),
f_default_menu(NULL),
f_clear_search_hits(NULL),
f_graphical_map(NULL),
f_search_form(NULL),
f_search_menu_button(NULL),
f_print(NULL),
f_print2(NULL),
f_print_as(NULL),
f_move_mark_sensitive(0),
f_last_access_time(0),
f_locked(FALSE),
f_wm_delete_callback(NULL)
{
UAS_Common::request ((UAS_Receiver<UAS_LibraryDestroyedMsg> *) this);

View File

@@ -259,7 +259,7 @@ public:
PrefAgent::PrefAgent()
: f_shell(NULL)
: f_shell(NULL), f_top_panel(NULL), f_timeout(NULL)
{
}

View File

@@ -93,6 +93,9 @@ protected: // variables
inline
SearchResultsAgent::SearchResultsAgent()
: f_work_proc_id (0), f_popped_up(FALSE)
: f_work_proc_id (0), f_popped_up(FALSE), f_my_ale(NULL), f_retain(FALSE),
f_results(NULL), f_selected_item(0), f_retain_toggle(NULL), f_query_text(NULL),
f_hits_label(NULL), f_scope_label(NULL), f_docs_to_display(0), f_count(0),
f_scale(0), f_header_indent(0)
{
}

View File

@@ -77,6 +77,7 @@ extern char g_top_locator[];
UrlAgent::UrlAgent () {
fShell = NULL;
fPrefWindow = 0;
fPoppedUp = FALSE;
}
UrlAgent::~UrlAgent () {

View File

@@ -95,7 +95,8 @@ EnvMgr::EnvMgr() : f_argc(0),
f_lang(NULL),
f_secondary(False),
f_verbose(False),
f_debug(False)
f_debug(False),
f_autohelp(False)
{
const char* lang;
if ((lang = getenv("LC_ALL")) == NULL)

View File

@@ -70,7 +70,7 @@ struct HistoryDelete : public Destructable
struct HistoryAdd : public Destructable
{
HistoryAdd (UAS_Pointer<UAS_Common> &node_ptr)
: f_new_entry(node_ptr) { }
: f_new_entry(node_ptr), f_moving(false) { }
UAS_Pointer<UAS_Common> f_new_entry; // UAS_Pointer to UAS_Common displayed.
bool f_moving; // True if a moved entry.

View File

@@ -98,7 +98,8 @@ class Graphic: public UAS_Base {
fPixmap (0),
fDetachedPixmap (0),
fDetached (0),
fObj (doc->create_embedded_object (locator)) {
fObj (doc->create_embedded_object (locator)),
fagent(NULL) {
}
~Graphic () {

View File

@@ -66,6 +66,7 @@
LocalHistoryMgr::LocalHistoryMgr()
{
f_current = NULL;
f_first = NULL;
}

View File

@@ -33,7 +33,7 @@ class LocalHistoryEntry
{
private: // functions
LocalHistoryEntry (UAS_Pointer<UAS_Common> &doc_ptr)
: f_doc_ptr (doc_ptr), f_anchor (NULL) { }
: f_doc_ptr (doc_ptr), f_anchor (NULL), f_previous(NULL), f_next(NULL) { }
LocalHistoryEntry()
{ }
~LocalHistoryEntry();

View File

@@ -64,6 +64,8 @@ WorkspaceMgr::WorkspaceMgr()
DtWsmAddCurrentWorkspaceCallback( window_system().toplevel(),
(DtWsmWsChangeProc) PrimaryWorkspace_cb, this );
f_actual = 0;
}

View File

@@ -236,7 +236,11 @@ CanvasRenderer::CanvasRenderer(int font_scale)
f_link_idx (-1),
f_font_scale(font_scale),
fBogusSymbol(gElemSymTab->intern("%BOGUS")),
f_level(0)
f_level(0),
f_vcc(0),
f_current_container(NULL),
f_current_displayable(NULL),
f_default_features(NULL)
{
// make symbols
for ( int i=0; i < REND_SYMBOLS; i++)

View File

@@ -64,6 +64,8 @@ AppPrintData::AppPrintData()
f_print_shell = NULL;
f_print_only = FALSE;
f_outline_element = NULL;
f_print_list = NULL;
f_pshell_parent = NULL;
};
//--------- Destructors ----------------------------------

View File

@@ -226,7 +226,10 @@ public:
Shell_Info (Widget w)
: f_shell (w),
f_size_hints (NULL),
f_restore (False)
f_restore (False),
f_has_size_hints(False),
f_iconic(False),
f_has_wm_state(False)
{ }
public:
@@ -252,7 +255,14 @@ WindowSystem::WindowSystem (int &argc, char *argv[])
f_shell_list (20),
f_cursor_stack_pos(-1),
f_dtinfo_font(NULL),
f_dtinfo_space_font(NULL)
f_dtinfo_space_font(NULL),
f_print_display(NULL),
f_default_print_pixmap(0),
f_print_defpix_width(0),
f_print_defpix_height(0),
f_detached_width(0),
f_detached_height(0),
f_print_screen(NULL)
{
f_argc = &argc;
f_argv = argv;

View File

@@ -105,7 +105,8 @@ QueryEditor::QueryEditor(UAS_SearchEngine& search_engine)
: f_query (NULL),
f_query_view (NULL),
f_shell (NULL),
f_null_terms (0)
f_null_terms (0),
f_min_term_width(0)
{
f_query_editor = this;

View File

@@ -52,7 +52,8 @@ UAS_BookcaseEntry::UAS_BookcaseEntry(UAS_Pointer<UAS_Common> &bookcase,
int searchable)
: f_searchable(searchable),
f_name(0),
f_base_num(-1)
f_base_num(-1),
f_infolib_num(0)
{
int len;

View File

@@ -32,7 +32,7 @@
#include "StyleSheet/FeatureValue.h"
Tml_TextRenderer::Tml_TextRenderer(ostringstream &ostr, UAS_SearchZones &zones) :
f_ostr(ostr), f_zones(zones)
f_ostr(ostr), f_zones(zones), f_current_level(0)
{
}

View File

@@ -17,7 +17,7 @@ template<class K, class V> class DictLink
DictLink<K,V>* pre;
DictLink<K,V>* suc;
DictLink(const K& k, const V& v) : key(k), value(v) { };
DictLink(const K& k, const V& v) : key(k), value(v), pre(NULL), suc(NULL) { };
~DictLink() { if (suc) delete suc; } // delete all links recursively
};