debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Centralize catgets() calls through MsgCat

Browse Source 
CDE has relied upon catgets() implementations following a relaxed
interpretation of the XPG internationalization standard that ignored
-1, the standard error value returned by catopen, as the catalog
argument. However, this same behavior causes segmentation faults with
the musl C library.

This patch:

- Centralizes (with the exception of ToolTalk) all calls to catopen(),
  catgets(), and catclose() through MsgCat within the DtSvc library.
- Prevents calls to catgets() and catclose() that rely upon
  undefined behavior.
- Eliminates a number of bespoke catgets() wrappers, including multiple
  redundant caching implementations designed to work around a design
  peculiarity in HP/UX.
- Eases building CDE without XPG internationalization support by providing
  the appropriate macros.
This commit is contained in:
Lev Kujawski
2021-01-30 20:05:13 -07:00
committed by Jon Trulson
parent 8278e0eae3
commit 7010b2c11b
241 changed files with 3153 additions and 3493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cde/programs/dtinfo/dtinfo/src/Managers/CatMgr.C
View File

@@ -54,14 +54,14 @@ CatMgr::CatMgr() : f_msg(NULL), f_default(NULL)
cerr << "(WARNING) NLSPATH not specified" << '\n' << flush;
#endif
f_catd = catopen(CATALOG_PREFIX, NL_CAT_LOCALE);
f_catd = CATOPEN(CATALOG_PREFIX, NL_CAT_LOCALE);
// setup default message
if (is_open(f_catd)) {
#ifdef DEBUG
cerr << "(DEBUG) catopen succeeded." << '\n' << flush;
#endif
char* msg = ::catgets(f_catd, Set_CatMgr, DEFAULT_MSG,
char* msg = ::CATGETS(f_catd, Set_CatMgr, DEFAULT_MSG,
"default message not found.");
len = strlen(msg);
f_default = new char[len + 1];
@@ -94,7 +94,7 @@ CatMgr::~CatMgr()
delete[] f_default;
if (is_open(f_catd)) {
int status = catclose(f_catd);
int status = CATCLOSE(f_catd);
if (status < 0) {
#ifdef DEBUG
cerr << "(ERROR) catclose failed." << '\n' << flush;
@@ -127,9 +127,9 @@ CatMgr::catgets(int set_num, int msg_num, const char* def)
if (is_open(f_catd)) {
char* msg;
if (def)
msg = ::catgets(f_catd, set_num, msg_num, def);
msg = ::CATGETS(f_catd, set_num, msg_num, def);
else
msg = ::catgets(f_catd, set_num, msg_num, f_default);
msg = ::CATGETS(f_catd, set_num, msg_num, f_default);
int msglen = strlen(msg);
len = msglen;
f_msg = new char[msglen + 1];

2
cde/programs/dtinfo/dtinfo/src/Managers/CatMgr.hh
View File

@@ -27,7 +27,7 @@
#ifndef __CATMGR_HH__
#define __CATMGR_HH__
#include <nl_types.h>
#include <Dt/MsgCatP.h>
#include "Registration.hh"