debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dthelp/helpgen.c: coverity CID 175085; use after free

Browse Source
This commit is contained in:
Jon Trulson
2018-03-31 18:21:14 -06:00
parent ec93faffe7
commit 7752966865
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cde/programs/dthelp/dthelpgen/helpgen.c
View File

@@ -384,7 +384,7 @@ CreateFamily (
char *title = NULL; char *title = NULL;
char *abstract = NULL; char *abstract = NULL;
char *list = NULL; char *list = NULL;
char *token; char *token = NULL;
char *ptr; char *ptr;
char *bitmap = NULL; char *bitmap = NULL;
char familyName [20]; /* FAMILY%d */ char familyName [20]; /* FAMILY%d */
@@ -501,8 +501,11 @@ CreateFamily (
CreateVolumeLink (canvas,out_topic, token) == 0) CreateVolumeLink (canvas,out_topic, token) == 0)
count++; count++;
if (token && *token != '\0' && *token != '\n') if (token)
{
free ((void *) token); free ((void *) token);
token = NULL;
}
} while (list && *list != '\0'); } while (list && *list != '\0');
@@ -580,7 +583,6 @@ CreateFamily (
XrmDestroyDatabase (db); XrmDestroyDatabase (db);
} }
free (token);
return result; return result;
} }