handle missing return values

cde/lib/DtHelp/FormatSDL.c

@@ -8732,7 +8732,7 @@ FormatSDLTitle(
  * Purpose:
  *
  ******************************************************************************/
-static	int
+static	void
 SetGhostLink(
     _DtCvLinkDb		 link_data,
     _DtCvSegment	*segments,

cde/lib/DtHelp/Graphics.c

@@ -2916,6 +2916,7 @@ size_t _DtGrRead(
                 return (num_items);
         }
     }
+    return 0;
 }
 
 /******************************************************************************
@@ -2969,6 +2970,7 @@ int _DtGrSeek(
         else
             return(-1); /* Failure */
     }
+    return -1;
 }
 
 /******************************************************************************
@@ -2997,6 +2999,7 @@ int _DtGrGetChar(
         else
 	    return ((unsigned char) *(stream->source.buffer.current++));
     }
+    return EOF;
 }
 
 /******************************************************************************
@@ -3058,4 +3061,5 @@ char *_DtGrGetString(
         *buffer = '\0';
         return (save);
     }
+    return NULL;
 }

cde/lib/DtHelp/Selection.c

@@ -379,7 +379,7 @@ SkipOtherLines(
  * Function: CheckAndSwitchPoints
  *
  *****************************************************************************/
-static int
+static void
 CheckAndSwitchPoints(
     _DtCvSelectData *pt1,
     _DtCvSelectData *pt2)

cde/lib/DtHelp/il/ilpipe.c

@@ -1364,4 +1364,5 @@ ilError                 error;
 
             }   /* END while true: execute strips */
         }       /* END switch pipe state */
+    return IL_EXECUTE_AGAIN;
 }

cde/lib/DtSearch/ausexit.c

@@ -111,6 +111,7 @@ void	(*austext_exit_last) (int) =	NULL;
 /*		DtSearchExit		*/
 /*					*/
 /****************************************/
+__attribute__((noreturn))
 void	DtSearchExit (int return_code)
 {
     if (austext_exit_first != NULL)

cde/lib/DtSearch/dtsrjoint.c

@@ -579,11 +579,9 @@ static DtSrResult *ditto_sort (DtSrResult * lst)
 	    return merge_by_prox (ditto_sort (lst), ditto_sort (lst2));
 	case DtSrSORT_DATE:
 	    return merge_by_date (ditto_sort (lst), ditto_sort (lst2));
-	default:
-	    fprintf (aa_stderr, PROGNAME "525 Invalid Sort Type %d.\n",
-		ditsort_type);
-	    DtSearchExit (32);
     }
+    fprintf (aa_stderr, PROGNAME "525 Invalid Sort Type %d.\n", ditsort_type);
+    DtSearchExit (32);
 }  /* ditto_sort() */
 
 

cde/lib/DtSvc/DtUtil1/ActionTt.c

@@ -852,10 +852,9 @@ static int _DtAct_tt_message_arg_reptype( Tt_message message, int arg )
 
     status = tt_message_arg_ival( message, arg, &testVal );
 
-    if (status == TT_OK)
-	return( DtACT_TT_REP_INT);
-    else if (status == TT_ERR_NUM)
-	return( DtACT_TT_REP_BUFFER );
+    if (status == TT_ERR_NUM)
+	return DtACT_TT_REP_BUFFER;
+    return DtACT_TT_REP_INT;
 }
 
 /******************************************************************************

cde/lib/csa/connection.c

@@ -864,5 +864,6 @@ regstat4_to_dtcmstatus(Registration_Status_4 stat4)
 	case confused_4:
 		return (CSA_E_FAILURE);
 	}
+	return CSA_E_FAILURE;
 }
 

cde/lib/csa/match.c

@@ -1046,7 +1046,7 @@ match_this_attribute(Appt_4 *appt, cms_attribute attr, CSA_enum op)
 
 		return (_DtCm_match_sint32_attribute(&oldattr,
 			(attr.value ? &matchattr : NULL), op));
-	defalut:
+	default:
 		return (B_FALSE);
 	}
 }