debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtdbcache: remove incorrect comment block and tmpnam_buf var (not used)

Browse Source 
With Aaron's fixes to dtdbcache fixing a potential coredump, the
comment block in the write_db() function regarding tmpnam() no longer
applies, and the tmpnam_buf variable is no longer used.

So, remove them :)
This commit is contained in:
Jon Trulson
2012-08-07 17:43:32 -06:00
parent 80f456e3b5
commit 91011085a4
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cde/lib/DtSvc/DtUtil1/MMDb.c
View File

@@ -674,11 +674,6 @@ write_db(DtDtsMMHeader *header, void *index, int size, const char *CacheFile)
int fd; int fd;
mode_t cmask = umask((mode_t)077); mode_t cmask = umask((mode_t)077);
char *tmpfile; char *tmpfile;
/* tempnam(3) is affected by the TMPDIR environment variable. */
/* This creates problems for rename() is "tmpfile" and "cacheFile" */
/* are on different file systems. Use tmpnam(3) to create the */
/* unique file name instead. */
char tmpnam_buf[L_tmpnam + 1];
if ((tmpfile = malloc(sizeof(_DTDTSMMTEMPDIR) + if ((tmpfile = malloc(sizeof(_DTDTSMMTEMPDIR) +
sizeof(_DTDTSMMTEMPFILE) + 7)) == NULL) { sizeof(_DTDTSMMTEMPFILE) + 7)) == NULL) {