debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mp_rpc_server.C: limit iteration of svc_fdset to FD_SETSIZE, as per spec.

Browse Source 
In init() there was code iterating over all of the possible file
descriptors in a svc_fdset.  fdsets are limited to FD_SETSIZE.  This
caused coredumps on FreeBSD 10, and possibly other hidden issues.

Moving to poll(), rather than select() would be better, but is a bigger
job.  For now, just limit to the FD_SETSIZE that select() requires.
This commit is contained in:
Jon Trulson
2014-03-10 14:49:37 -06:00
parent 9b9b3430ec
commit 9f0fbc3015
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cde/lib/tt/slib/mp_rpc_server.C
View File

@@ -244,8 +244,7 @@ init(void (*service_fn)(struct svc_req *, SVCXPRT *))
(void)endnetconfig(handlep); (void)endnetconfig(handlep);
#endif /* OPT_TLI */ #endif /* OPT_TLI */
// now figure out what fd the rpc package is using // now figure out what fd the rpc package is using
int maxfds = _tt_global->maxfds(); for (int i=0; i < FD_SETSIZE; i++) {
for (int i=0; i < maxfds; i++) {
if (FD_ISSET(i, &svc_fdset)) { if (FD_ISSET(i, &svc_fdset)) {
_rpc_fd = i; _rpc_fd = i;
} }