Centralize catgets() calls through MsgCat

CDE has relied upon catgets() implementations following a relaxed
interpretation of the XPG internationalization standard that ignored
-1, the standard error value returned by catopen, as the catalog
argument. However, this same behavior causes segmentation faults with
the musl C library.

This patch:

- Centralizes (with the exception of ToolTalk) all calls to catopen(),
  catgets(), and catclose() through MsgCat within the DtSvc library.
- Prevents calls to catgets() and catclose() that rely upon
  undefined behavior.
- Eliminates a number of bespoke catgets() wrappers, including multiple
  redundant caching implementations designed to work around a design
  peculiarity in HP/UX.
- Eases building CDE without XPG internationalization support by providing
  the appropriate macros.
This commit is contained in:
Lev Kujawski
2021-01-30 20:05:13 -07:00
committed by Jon Trulson
parent 3379999106
commit a6ea2a2d52
241 changed files with 3154 additions and 3498 deletions

View File

@@ -36,7 +36,7 @@
#ifdef I18N_MSG
#include <nl_types.h>
#include <Dt/MsgCatP.h>
#if !defined(NL_CAT_LOCALE)
#define NL_CAT_LOCALE 0
@@ -81,21 +81,14 @@ DtPdmGetMessage(
int n,
char * s)
{
char *msg;
nl_catd catopen();
char *catgets();
static int first = 1;
static nl_catd nlmsg_fd;
if(set == -1 || n == -1)
return s;
if(first)
{
first = 0;
nlmsg_fd = catopen(DTPDM_CAT_NAME, NL_CAT_LOCALE);
nlmsg_fd = CATOPEN(DTPDM_CAT_NAME, NL_CAT_LOCALE);
}
msg=catgets(nlmsg_fd,set,n,s);
return (msg);
return CATGETS(nlmsg_fd,set,n,s);
}
#endif /* I18N_MSG */

View File

@@ -37,7 +37,7 @@
#define _PdmMsgs_h
#ifdef I18N_MSG
#include <nl_types.h>
#include <Dt/MsgCatP.h>
#define DTPDM_GETMESSAGE(set, number, string) \
DtPdmGetMessage(set, number, string)