debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtlogin: resolve more static analysis warnings

Browse Source
This commit is contained in:
Peter Howkins
2014-12-27 23:13:59 +00:00
parent c768260785
commit ab743c37e6
9 changed files with 30 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cde/programs/dtlogin/session.c
View File

@@ -644,7 +644,7 @@ int
LoadXloginResources( struct display *d )
{
char cmd[1024];
char *language="";
char *language = NULL;
char *lang_key="";
char *authority="";
char *auth_key="";
@@ -1943,6 +1943,8 @@ RunGreeter( struct display *d, struct greet_info *greet,
char *path;
struct greet_state state = {};
int notify_dt;
int dupfp = -1;
int dupfp2 = -1;
#ifdef __PASSWD_ETC
# ifndef U_NAMELEN
@@ -2126,7 +2128,8 @@ RunGreeter( struct display *d, struct greet_info *greet,
* Writing to file descriptor 1 goes to response pipe instead.
*/
close(1);
if(-1 == dup(response[1])) {
dupfp = dup(response[1]);
if(-1 == dupfp) {
perror(strerror(errno));
}
close(response[0]);
@@ -2136,7 +2139,8 @@ RunGreeter( struct display *d, struct greet_info *greet,
* Reading from file descriptor 0 reads from request pipe instead.
*/
close(0);
if(-1 == dup(request[0])) {
dupfp2 = dup(request[0]);
if(-1 == dupfp2) {
perror(strerror(errno));
}
close(request[0]);