dtinfo: fix coverity issues related to null checks after dereference

2018-04-04 22:42:06 +01:00
parent 2b15c4057e
commit bc28c20524
6 changed files with 24 additions and 22 deletions
--- a/cde/programs/dtinfo/dtinfogen/infolib/etc/AusText.C
+++ b/cde/programs/dtinfo/dtinfogen/infolib/etc/AusText.C
@@ -77,7 +77,7 @@ AusText::~AusText()
 {
  store->deActivateZone ( f_base );

-  if ( store ) { delete store; }
+  delete store;
  if ( f_search_store ) { delete f_search_store; }
 }

--- a/cde/programs/dtinfo/dtinfogen/infolib/etc/dtinfogen_worker.c
+++ b/cde/programs/dtinfo/dtinfogen/infolib/etc/dtinfogen_worker.c
@@ -828,8 +828,7 @@ makeAbsPathEnv(char *var)
    snprintf(newVar, pathlen, "%s=%s", var, newPath);
    putenv(newVar);

-    if (newPath)
-	XtFree(newPath);
+    XtFree(newPath);

    return newVar;
 }