debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtfile/SharedProcs.c: coverity CID 89068; use after free

Browse Source
This commit is contained in:
Jon Trulson
2018-03-31 17:21:34 -06:00
parent 0c0b77a509
commit c32b5db653
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cde/programs/dtfile/SharedProcs.c
View File

@@ -787,9 +787,10 @@ _DtCheckAndFreePixmapData(
XtFree( tmp ); XtFree( tmp );
} }
DtDtsFreeAttributeValue(pixmapData->instanceIconName); DtDtsFreeAttributeValue(pixmapData->instanceIconName);
pixmapData->instanceIconName = NULL;
if (iconGadget->icon.pixmap == 0 || if (iconGadget->icon.pixmap == 0 ||
iconGadget->icon.pixmap_width == 0 || iconGadget->icon.pixmap_width == 0 ||
@@ -824,15 +825,17 @@ _DtCheckAndFreePixmapData(
XtSetArg(args[0], XmNimageName, pixmapData->iconFileName); XtSetArg(args[0], XmNimageName, pixmapData->iconFileName);
XtSetValues((Widget) iconGadget, args, 1); XtSetValues((Widget) iconGadget, args, 1);
DtDtsFreeAttributeValue(pixmapData->iconName); DtDtsFreeAttributeValue(pixmapData->iconName);
pixmapData->iconName = NULL;
} }
} }
else else
{ {
DtDtsFreeAttributeValue(pixmapData->iconName); DtDtsFreeAttributeValue(pixmapData->iconName);
pixmapData->iconName = NULL;
} }
DtDtsFreeAttributeValue(pixmapData->hostPrefix); DtDtsFreeAttributeValue(pixmapData->hostPrefix);