debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kill most warnings in lib/DtTerm.

Browse Source 
Mostly missing headers, explicit parentheses and new prototypes.

Some Caveats:
* I haven't compile-tested the SVR4 getpty file, it might need another tweak
* There were operator precedence bugs in TermPrimCursor.c and TermPrimRender.c
  (^ vs. !=).  This might change behaviour, but at least I haven't experienced
  any crashes ...
* This adds a little more dependencies for include ordering, but unless we
  want to play the "headers that include headers that include headers..." game,
  this is unavoidable.
This commit is contained in:
Pascal Stumpf
2013-07-22 12:34:15 +02:00
committed by Jon Trulson
parent 8f98ac92cd
commit dc0e8ea74d
43 changed files with 437 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cde/lib/DtTerm/TermPrim/TermPrimUtil.c
View File

@@ -467,7 +467,7 @@ _DtTermPrimStartLog(Widget w)
_bA_dump();
#endif /* BBA */
(void) execl(DEFAULT_SHELL, DEFAULT_SHELL_ARGV0,
"-c", &tw->term.logFile[1], 0);
"-c", &tw->term.logFile[1], NULL);
(void) fprintf(stderr, " Can't exec \"%s\"\n",
&tw->term.logFile[1]);
(void) exit(1);
@@ -484,7 +484,7 @@ _DtTermPrimStartLog(Widget w)
if (access(tw->term.logFile, W_OK) < 0) {
return;
}
} else if (cp = strrchr(tw->term.logFile, '/')) {
} else if ((cp = strrchr(tw->term.logFile, '/'))) {
*cp = 0;
i = access(tw->term.logFile, W_OK);
*cp = '/';