Fix a bunch of -Wempty-body warnings reported by clang

Many of these were real bugs, like:

if (cond);
   do_something

etc...

Others were just cosmetic - like placing the ';' on a separate line to
make the intention clear.
This commit is contained in:
Jon Trulson
2021-12-11 13:10:24 -07:00
parent 18e25ce273
commit dda11f0e38
11 changed files with 28 additions and 18 deletions

View File

@@ -417,9 +417,14 @@ DialogManager::forceUpdate( Widget w )
if ( !w )
return;
XtAppContext cxt=XtWidgetToApplicationContext( w );
for (diashell=w;!XtIsShell(diashell);diashell=XtParent(diashell));
for ( topshell=diashell;XtIsTopLevelShell( topshell );
topshell = XtParent( topshell ) );
for (diashell=w;
!XtIsShell(diashell);
diashell=XtParent(diashell))
;
for ( topshell=diashell;
XtIsTopLevelShell( topshell );
topshell = XtParent( topshell ) )
;
// if (XtIsRealized(diashell) && XtIsRealized(topshell)){
dpy=XtDisplay(diashell);

View File

@@ -2050,8 +2050,8 @@ DtMail::MailRc::expand(char *name)
close(pivec[1]);
l = read(pivec[0], xname, LINESIZE);
close(pivec[0]);
while (wait(&s) != pid);
;
while (wait(&s) != pid)
;
s &= 0377;
if (s != 0 && s != SIGPIPE) {
fprintf(stderr, "Echo failed\n");

View File

@@ -789,8 +789,9 @@ DtMailServer::retrieve_messages(DtMailEnv &error)
if (ok != DTME_MailServerAccess_SocketIOError)
if (ok == DTME_NoError)
ok = ptrans_quit();
else
else {
(void) ptrans_quit();
}
vtalarm_setitimer(0);
SockClose(_sockfp);
_sockfp = NULL;