dtlogin: Resolve some coverity issues, including those thought previously fixed

2018-04-28 23:47:05 +01:00
parent 399c1e08c3
commit e14e74231c
5 changed files with 15 additions and 11 deletions
--- a/cde/programs/dtlogin/vgmain.c
+++ b/cde/programs/dtlogin/vgmain.c
@@ -1557,7 +1557,8 @@ MakeGreeting( void )
 	 */
 	 

-	if ( strlen(greetInfo.labelString) == 0 	||
+	if ( !greetInfo.labelString			||
+	     strlen(greetInfo.labelString) == 0 	||
 	     strcmp(greetInfo.labelString, "None") == 0	||
 	     strcmp(greetInfo.labelString, "none") == 0	)