post_install: fix shellcheck warnings

cde/admin/IntegTools/post_install/linux/configRun.src

@@ -9,9 +9,6 @@ XCOMM #######
 #define HASH #
 #define STAR *
 
-PRODUCT=CDE
-FILESET=CDE-RUN
-DO_CONFIGURATION=""
 retval=0
 
 CreateAppConfigDirectory()
@@ -21,41 +18,42 @@ CreateAppConfigDirectory()
   HASH all of its subdirectories
   HASH
 
-    cd $DT_CONFIG_TOP
-    if [ ! -d $APPCONFIG ]
+    cd "$DT_CONFIG_TOP" || exit
+    if [ ! -d "$APPCONFIG" ]
     then
-	mkdir $APPCONFIG
+	mkdir "$APPCONFIG"
     fi
 
-    cd $APPCONFIG
+    cd "$APPCONFIG" || exit
 
     for i in $APPCONFIG_DIRS
     do
-	if [ ! -d $i ]
+	(
+	if [ ! -d "$i" ]
 	then
-	    mkdir $i
+	    mkdir "$i"
 	fi
-	cd $i
+	cd "$i" || exit
         HASH
 	HASH for each locale
 	HASH
 	for j in $DT_TOP/$APPCONFIG/$i/STAR
 	do
-	    if [ ! -d `basename $j` ]
+	    if [ ! -d "$(basename "$j")" ]
 	    then
-		mkdir `basename $j`
+		mkdir "$(basename "$j")"
 	    fi
 	done
-	cd ..
+	)
     done
 
 }
 
 doDttermTerminfo()
 {
-    if [ -f $DT_TOP/config/dtterm.ti ]
+    if [ -f "$DT_TOP/config/dtterm.ti" ]
     then
-	tic $DT_TOP/config/dtterm.ti
+	tic "$DT_TOP/config/dtterm.ti"
 	if [ -f /usr/share/lib/terminfo/d/dtterm ]
 	then
 	    chown bin /usr/share/lib/terminfo/d/dtterm
@@ -69,7 +67,7 @@ doDttermTerminfo()
 		chmod 644 /usr/share/terminfo/d/dtterm
 	    fi
 	fi
-	if [ ! -f /usr/share/lib/terminfo/d/dtterm -a ! -f /usr/share/terminfo/d/dtterm ]
+	if [ ! -f /usr/share/lib/terminfo/d/dtterm ] && [ ! -f /usr/share/terminfo/d/dtterm ]
 	then
 	    echo "Unable to compile $DT_TOP/config/dtterm.ti"	    
 	fi
@@ -80,19 +78,19 @@ doDttermTerminfo()
 
 RemoveRunFiles()
 {
-    while read SRC
+    while read -r SRC
     do
       if [ "$SRC" != "" ]
       then
-	rm -f $SRC
+	rm -f "$SRC"
 	dirname=${SRC%/STAR}
-	if [ -d $dirname ]
+	if [ -d "$dirname" ]
 	then
-	  cd $dirname
+	  cd "$dirname" || exit
 	  while [ "$dirname" != "$CDE_TOP" ]
 	  do
 	    cd ..
-	    rmdir ${dirname##STAR/} >/dev/null 2>/dev/null
+	    rmdir "${dirname##STAR/}" >/dev/null 2>/dev/null
 	    dirname=${dirname%/STAR}
 	  done
 	fi
@@ -122,7 +120,7 @@ XCOMM        exists    the link is correct    /usr/dt/link
 
 PrintUsage()
 {
-  echo "Usage:" $0 "[OPERATION]"
+  echo "Usage:" "$0" "[OPERATION]"
   echo ""
   echo "Operations:"
   echo "    -e        configure"
@@ -140,22 +138,16 @@ XCOMM				Main Body
 XCOMM
 XCOMM ##########################################################################
 
-PRODUCT=CDE
-FILESET=CDE-RUN
-
 DT_TOP=CDE_INSTALLATION_TOP
 DT_CONFIG_TOP=CDE_CONFIGURATION_TOP
 DT_TEMP_TOP=CDE_LOGFILES_TOP
-ROOT=/
 
 retval=0
 
 APPCONFIG=appconfig
 APPCONFIG_DIRS="appmanager help icons types"
-PRINTERS=""
-DEFAULT_PRINTER="DtPrint"
 
-  HandleOption $*
+  HandleOption "$*"
 
   if [ "$OPERATION" = "usage" ]
   then
@@ -175,12 +167,12 @@ DEFAULT_PRINTER="DtPrint"
 	mkdir -p $DT_TEMP_TOP/$APPCONFIG/appmanager
     fi
 
-    cd $DT_TEMP_TOP
+    cd "$DT_TEMP_TOP" || exit
     mv $APPCONFIG/appmanager .hidden-appmanager
-    chmod -R 755 *
+    chmod -R 755 -- *
     chmod 755 .hidden-appmanager
-    chown -R bin *
-    chgrp -R bin *
+    chown -R bin -- *
+    chgrp -R bin -- *
     mv .hidden-appmanager $APPCONFIG/appmanager
     chmod 755 .
     chown bin .
@@ -209,14 +201,14 @@ DEFAULT_PRINTER="DtPrint"
     HASH Configure Xsession.d
     HASH
 
-    cd $DT_CONFIG_TOP/config
+    cd $DT_CONFIG_TOP/config || exit
     if [ ! -d Xsession.d ]
     then
 	mkdir Xsession.d
     fi
 
-    cd $DT_CONFIG_TOP
-    chmod -R 755 *
+    cd $DT_CONFIG_TOP || exit
+    chmod -R 755 -- *
 
     doDttermTerminfo