debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtfile/Help.c: coverity CID 88484; use after free

Browse Source
This commit is contained in:
Jon Trulson
2018-03-31 18:11:14 -06:00
parent 4543bc6192
commit ec93faffe7
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cde/programs/dtfile/Help.c
View File

@@ -473,7 +473,7 @@ MapFileTypeToHelpString(
char * desc; char * desc;
Boolean isAction; Boolean isAction;
char * tmpStr; char * tmpStr;
char * label; char * label = NULL;
/* Special case for the 2 built in directory commands */ /* Special case for the 2 built in directory commands */
if (strcmp(filetype, openNewView) == 0) if (strcmp(filetype, openNewView) == 0)
@@ -536,6 +536,7 @@ MapFileTypeToHelpString(
buf = XtMalloc(strlen(label) + strlen(helpPattern) + 100); buf = XtMalloc(strlen(label) + strlen(helpPattern) + 100);
sprintf(buf, helpPattern, label); sprintf(buf, helpPattern, label);
DtDtsFreeAttributeValue(label); DtDtsFreeAttributeValue(label);
label = NULL;
} }
else else
{ {