debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtwm/PopUpMenu: Coverity (memory corruption, moderate)

Browse Source
This commit is contained in:
Jon Trulson
2014-12-26 17:30:50 -07:00
parent 611dda1831
commit f05c124807
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cde/programs/dtwm/PopupMenu.c
View File

@@ -220,18 +220,19 @@ AddWorkspaceCB (Widget w,
{ {
SwitchData * switch_data; SwitchData * switch_data = NULL;
char * switch_name; char * switch_name;
char * temp_name; char * temp_name;
int append; int append;
int i; int i;
int slen;
/* Get the beginning part of the new name */ /* Get the beginning part of the new name */
temp_name = FPGETMESSAGE (82, 35, "New"); temp_name = FPGETMESSAGE (82, 35, "New");
switch_name = XtMalloc (strlen (temp_name) + 5); slen = strlen (temp_name) + 5 + 1;
switch_name = XtCalloc(1, slen);
strcpy (switch_name, temp_name); strcpy (switch_name, temp_name);
@@ -265,7 +266,7 @@ AddWorkspaceCB (Widget w,
if (strcmp (switch_name, switch_data->switch_names[i]) == 0) if (strcmp (switch_name, switch_data->switch_names[i]) == 0)
{ {
good_name = False; good_name = False;
sprintf (switch_name, "%s_%d", temp_name, append); snprintf (switch_name, slen - 1, "%s_%d", temp_name, append);
continue; continue;
} }
} }