debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ttauth: Coverity (memory corruption)

Browse Source
This commit is contained in:
Jon Trulson
2014-12-26 14:12:10 -07:00
parent e18ac00c82
commit f719d20b6c
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cde/lib/tt/bin/ttauth/process.c
View File

@@ -1252,7 +1252,7 @@ static int do_add (inputfilename, lineno, argc, argv)
char *netid; char *netid;
char *authname; char *authname;
char *authdata_hex; char *authdata_hex;
char *authdata; char *authdata = NULL;
int protodata_len, authdata_len; int protodata_len, authdata_len;
_tt_AuthFileEntry *entry; _tt_AuthFileEntry *entry;
_tt_AuthFileEntryList *list; _tt_AuthFileEntryList *list;
@@ -1345,6 +1345,9 @@ static int do_add (inputfilename, lineno, argc, argv)
entry->auth_data_length = authdata_len; entry->auth_data_length = authdata_len;
entry->auth_data = authdata; entry->auth_data = authdata;
/* Avoid a double free later on in the event of an error */
authdata = NULL;
if (!entry->protocol_name || if (!entry->protocol_name ||
(!entry->protocol_data && entry->protocol_data_length > 0) || (!entry->protocol_data && entry->protocol_data_length > 0) ||
!entry->network_id || !entry->auth_name || !entry->network_id || !entry->auth_name ||