debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile

Browse Source
This commit is contained in:
Jon Trulson
2018-04-03 20:59:48 -06:00
parent 8f7c874ba0
commit f7d09f054d
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cde/programs/dtfile/SharedProcs.c
View File

@@ -1631,6 +1631,7 @@ _DtPathFromInput(
FILE *pfp; FILE *pfp;
char command[MAXPATHLEN]; char command[MAXPATHLEN];
memset(command, 0, sizeof(command));
sprintf(command,"echo %s",path); sprintf(command,"echo %s",path);
if((pfp=popen(command,"r")) != NULL) if((pfp=popen(command,"r")) != NULL)
@@ -1654,9 +1655,13 @@ _DtPathFromInput(
read_ok = 0; read_ok = 0;
} }
if (read_ok) if (read_ok)
{ {
command[MAXPATHLEN-1] = '\0'; int slen = strlen(command);
/* need to remove the trailing newline safely*/
if (slen >= 1)
command[slen-1] = '\0';
XtFree(path); XtFree(path);
path = XtNewString(command); path = XtNewString(command);
pclose(pfp); pclose(pfp);