dtwm: Resolve coverity warnings related to uninitialised variables and missing return statements

2018-05-01 20:45:55 +01:00
parent ad373101d6
commit fa29d3776e
13 changed files with 30 additions and 16 deletions
--- a/cde/programs/dtwm/PopupMenu.c
+++ b/cde/programs/dtwm/PopupMenu.c
@@ -137,7 +137,7 @@ DeleteWorkspaceCB (Widget    w,

 {
   long delete_workspace = (long) client_data;
-   SwitchData * switch_data;
+   SwitchData * switch_data = NULL;
   int i;
   

@@ -152,9 +152,12 @@ DeleteWorkspaceCB (Widget    w,
         break;
      }
   }
-   
-   _DtWsmDeleteWorkspace (panel.shell, 
-                          switch_data->atom_names[delete_workspace]);
+
+   if(switch_data)
+   {
+      _DtWsmDeleteWorkspace (panel.shell, 
+                             switch_data->atom_names[delete_workspace]);
+   }
 }