debian/cdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dtlogin: Avoid putenv to fix issue with passing stack address

Browse Source 
putenv doesn't copy the data, so the stack address used here is plain
wrong. It _probably_ doesn't matter all that much because it's
immediately followed by execv(), but let's keep things clean.
This commit is contained in:
Patrick Georgi
2025-12-14 00:16:31 +01:00
parent b86eff35f0
commit fa31987221
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cde/programs/dtlogin/vgcallback.c
View File

@@ -1490,10 +1490,8 @@ RespondLangCB( Widget w, XtPointer client, XtPointer call)
/** but it does work ok. **/ /** but it does work ok. **/
/** notice the related code in chooser.c at the **/ /** notice the related code in chooser.c at the **/
/** beginning of main. **/ /** beginning of main. **/
char buff[128];
if (XmToggleButtonGadgetGetState(w)) { if (XmToggleButtonGadgetGetState(w)) {
snprintf(buff, sizeof(buff), "LANG=%s", (char *) client); setenv("LANG", client, 1);
putenv(buff);
execv(orig_argv[0], orig_argv); execv(orig_argv[0], orig_argv);
} }
} else { } else {