dtinfo/dtinfogen: Fix segfault introduced by over zealously fixing coverity resource leak

2018-04-05 18:16:10 +01:00
parent bc28c20524
commit 494fd64314
1 changed files with 4 additions and 2 deletions
--- a/cde/programs/dtinfo/dtinfogen/infolib/etc/SearchPath.C
+++ b/cde/programs/dtinfo/dtinfogen/infolib/etc/SearchPath.C
@@ -128,7 +128,7 @@ char *
 SearchPath::get_real_path( const char *file_name )
 {
  CC_TPtrSlistIterator<CC_String> path_it( *search_path_table );
-  FILE *fp;
+  FILE *fp = NULL;

  if (file_name == NULL || *file_name == '\0')
    return NULL;
@@ -149,7 +149,9 @@ SearchPath::get_real_path( const char *file_name )
      fclose( fp );
      return ( full_path_name );
    }
-    fclose( fp );
+    if(fp) {
+      fclose( fp );
+    }
  }

  return NULL;