dtaction: Fix unsafe use of sprintf
Patch from Robert Tomsick <robert+cde@tomsick.net>: I believe this fixes vulnerability #3 from CERT CA-1999-11.[1] The other uses of sprintf in DtAction seem to be safe. [1] https://www.cert.org/advisories/CA-1999-11.html
This commit is contained in:
@@ -898,8 +898,8 @@ GetUserPrompt( void )
|
||||
XmString cancelLabel;
|
||||
XmString okLabel;
|
||||
|
||||
sprintf(prompt, (GETMESSAGE(1,5, "Enter password for user %s:")),
|
||||
appArgs.user);
|
||||
snprintf(prompt, BUFSIZ, (GETMESSAGE(1,5, "Enter password for user %s:")),
|
||||
appArgs.user);
|
||||
xmString = XmStringCreateLocalized(prompt);
|
||||
xmString2 =XmStringCreateLocalized(GETMESSAGE(1,6, "Action Invoker - Password"));
|
||||
cancelLabel = XmStringCreateLocalized(GETMESSAGE(1,7, "Cancel"));
|
||||
|
||||
Reference in New Issue
Block a user